Re: [PATCH 1/2] dt-bindings: display: Add Solomon SSD1351 OLED controller

[Amit Barzilai]

Hi Krzysztof,

Thanks for the review.

> > +  solomon,width:
> > +    default: 128
> > +
> > +  solomon,height:
> > +    default: 128
>
> Drop both - deducible from the compatible.

Done. Both are dropped in v2; solomon,ssd-common.yaml already declares them
(as optional) and the driver supplies the 128x128 default from its
device_info.

> > +  rotation: true
>
> Either drop or reference panel-common (if this is a panel) or at least
> reference that property:
> $ref: /schemas/display/panel/panel-common.yaml#/properties/rotation

Dropped in v2. Rotation is being removed from the driver, so the property has
no consumer.

> > +            reset-gpios = <&gpio2 7>;
> > +            dc-gpios = <&gpio2 8>;
>
> Use proper defines for GPIO flags

Done. v2 includes <dt-bindings/gpio/gpio.h> and uses GPIO_ACTIVE_LOW for
reset-gpios (the SSD1351 reset is active-low) and GPIO_ACTIVE_HIGH for
dc-gpios.

I'm sending v2 as a standalone binding patch so it can land independently of
the driver, which is being reworked separately. dt_binding_check passes
cleanly.

Thanks,
Amit