Re: [PATCH v4 5/7] mm: selftests: Add shmem into memory failure test

[Lisa Wang]

On Fri, Jun 05, 2026 at 01:38:28PM +0200, David Hildenbrand (Arm) wrote:

[...snip...]

> >  static jmp_buf signal_jmp_buf;
> > @@ -165,17 +170,21 @@ static void check(struct __test_metadata *_metadata, FIXTURE_DATA(memory_failure
> >  	case MADV_HARD_CLEAN_PAGECACHE:
> >  	case MADV_SOFT_CLEAN_PAGECACHE:
> >  	case MADV_SOFT_DIRTY_PAGECACHE:
> > -		/* It is not expected to receive a SIGBUS signal. */
> > -		ASSERT_EQ(setjmp, 0);
> > -
> > +	case MADV_SOFT_DIRTY_SHMEM:
> >  		/* The page content should remain unchanged. */
> >  		ASSERT_TRUE(check_memory(vaddr, self->page_size));
> 
> You should likely use "fallthrough;" ... unless you are missing a break; here.

Thanks, will fix this in the next version.

Lisa

> 
> 
> -- 
> Cheers,
> 
> David