Re: [PATCH net-next] octeontx2-pf: add page pool ethtool statistics

From: Jakub Kicinski

Date: Mon Jun 15 2026 - 17:51:44 EST


On Mon, 15 Jun 2026 08:51:41 +0530 Ratheesh Kannoth wrote:
> Expose page pool allocator statistics through ethtool.
> When the interface is up, aggregate stats from each
> receive queue page pool and append the common page_pool ethtool stat
> block to the driver's private statistics set.

include/net/page_pool/helpers.h :

/* Deprecated driver-facing API, use netlink instead */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
int page_pool_ethtool_stats_get_count(void);
u8 *page_pool_ethtool_stats_get_strings(u8 *data);
u64 *page_pool_ethtool_stats_get(u64 *data, const void *stats);

Is the page pool in your driver shared by multiple netdevs?

If not just set netdev in page_pool_params
If yes then you need to explain it in the commit msg

Please note that net-next is closed for the next 2 weeks
--
pw-bot: cr