Re: [PATCH v4 2/2] xfs: prevent close() from hanging on frozen filesystems

From: Christoph Hellwig

Date: Tue Jun 16 2026 - 01:24:01 EST


On Tue, Jun 16, 2026 at 03:38:20AM +0000, Aditya Srivastava wrote:
> Also, rename the flags parameter in xfs_free_eofblocks() to trans_flags as
> suggested to make its usage stand out, and update existing callers to
> pass 0 to preserve standard blocking paths.

It is only renamed compared to the previous patches, because this
patch actually adds it.

> - error = xfs_trans_alloc(mp, &M_RES(mp)->tr_itruncate, 0, 0, 0, &tp);
> + error = xfs_trans_alloc(mp, &M_RES(mp)->tr_itruncate, 0, 0, trans_flags, &tp);

Overly long line here.

Otherwise this looks good.