Re: [PATCH 1/3] dt-bindings: mfd: s2mu005-pmic: reorder reg and interrupts properties
From: Kaustabh Chakraborty
Date: Tue Jun 16 2026 - 02:17:07 EST
On 2026-06-16 06:14 +02:00, Krzysztof Kozlowski wrote:
> On 15/06/2026 22:26, Kaustabh Chakraborty wrote:
>> As per convention, and as also reiterated by maintainers [1], the
>> properties in schema is to be ordered similar to how its done in
>> devicetree sources; starting from compatible and reg. Re-order the
>> properties in this schema accordingly.
>>
>> Link: https://lore.kernel.org/all/0240eb13-6c56-4879-8db7-b990a220a78f@xxxxxxxxxx [1]
>> Suggested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
>
> Honestly, nah... I commented on v6 so you change the patch. But you were
> posting this huge patchset faster than we can review (v6 and v7 posted
> on the same day!), so v7 got applied where you did not implement the
> comments. One small posting per 24h. One big posting per 2-3 days, not
> more often.
Fair, there were a lot of sashiko reviews, so I quickly addressed most
of them and send a v7. It is indeed a failure on my part. :(
> There is little benefit in fixing this single file.
Fine, I drop the series. I'd assumed it'd be at least fine to have it
before a stable release.
> Best regards,
> Krzysztof