Re: [PATCH v7 2/5] iio: adc: add Versal SysMon driver

[Andy Shevchenko]

On Mon, Jun 15, 2026 at 04:41:12PM +0100, Erim, Salih wrote:
> On 15/06/2026 15:22, Andy Shevchenko wrote:
> > On Mon, Jun 15, 2026 at 12:37:19AM +0100, Salih Erim wrote:

...

> > > +/**
> > > + * sysmon_core_probe() - Initialize Versal SysMon core
> > 
> > It is managed, please name it accordingly: devm_sysmon_core_probe().
> 
> Will rename to devm_sysmon_core_probe() and update callers.

I believe you also want to have a proper namespace. The sysmon is to broad.

The easiest solution is to name it as devm_versal_sysmon_core_probe().

> > > + * @dev: Parent device
> > > + * @regmap: Register map for hardware access
> > > + *
> > > + * Return: 0 on success, negative errno on failure.
> > > + */

-- 
With Best Regards,
Andy Shevchenko