Re: [PATCH v2 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property

[Neil Armstrong]

On 6/16/26 10:36, Krzysztof Kozlowski wrote:
> On 15/06/2026 18:57, Neil Armstrong wrote:
> > In order for the GCC votes on the GDSCs it provides to be propagated
> > to CX, CX needs to be declared as power domain of the GCC.
>
> I would be happier to see here short mentioning what is the effect of
> missing votes - do things work? - as justification why required
> property, thus ABI change, is justified.
>
> The DTS patches gave me that answer, but should be here as well the best.
>
> Well, don't want to stall anything here, so anyway:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Thanks I'll update the commit message with the same explanation as
the DT changes.

Thanks,
Neil

> > Document the missing power-domains property to that purpose.
> >
> > Fixes: 72a0ca203ca7 ("dt-bindings: clock: Add SM8450 GCC clock bindings")
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
>
>
>
>
> Best regards,
> Krzysztof