Re: [PATCH v2 2/2] iio: adc: add Axiado SARADC driver

[Petar Stepanovic]

On 6/11/2026 12:09 PM, Jonathan Cameron wrote:
>> +
>> +#define AX_SARADC_MANUAL_CTRL_EN(ch)           \
>> +     (AX_SARADC_MANUAL_CTRL_ENABLE |          \
> Why tabs to place the \ above and spaces here?  I don't mind
> that much which you use, but aim for consistency.

Thanks, Jonathan.

The indentation issue was not intentional. It was probably my mistake while copying and adjusting that code, and it looks like my editor replaced some tabs with spaces during the copy.

I will address all of these comments in v3 and clean up the formatting consistently across the driver.

[...]

>> +
>> +     regval = FIELD_PREP(AX_SARADC_GLOBAL_CTRL_CH_EN_MASK,
>> +                      GENMASK(soc_data->num_channels - 1, 0)) |
> For readability that G should be under the a of the line above so it's
> obvious this line starts with a parameter of FIELD_PREP.
>
> The particular form of indentation you have here with an effective 8 spaces
> after the start of the function call seems to be something I'm commenting
> on a lot at the moment. Is some tool defaulting to that?

Yes, that was the same indentation issue. I will fix the |FIELD_PREP()|alignment in v3 and check the rest of the driver for the same pattern.

Regards,
Petar