Re: [PATCH v3 2/3] iio: adc: Add ti-ads1110 support to ti-ads1100 driver

From: Andy Shevchenko

Date: Tue Jun 16 2026 - 05:07:02 EST


On Mon, Jun 15, 2026 at 05:29:17PM -0500, David Lechner wrote:
> On 6/13/26 2:09 PM, Jakub Szczudlo wrote:
> > Add ADS1110 support that have faster datarate than ADS1100, it also uses
> > internal voltage reference of 2.048V for measurement.

...

> > +#define ADS1100_MAX_DRDY_TIMEOUT 7500000
>
> Always nice to include the units in the identifier name.
>
> ADS1100_MAX_DRDY_TIMEOUT_us

I think for seconds unit we stuck with capital letters.
But I appreciate the attempt.

--
With Best Regards,
Andy Shevchenko