Re: [PATCH v3 07/12] iio: dac: ad5686: add ldac gpio

From: Andy Shevchenko

Date: Tue Jun 16 2026 - 06:37:25 EST


On Tue, Jun 16, 2026 at 09:21:13AM +0100, Rodrigo Alencar via B4 Relay wrote:

> If wired LDAC, should be held low when unused (pin is active-low), which
> allows for synchronous DAC updates. This will be used to update all the
> channels at the same time when adding buffer support.

...

> +struct gpio_desc;

+ blank line to decouple generic declarations from local ones?

> struct ad5686_state;

--
With Best Regards,
Andy Shevchenko