Re: [PATCH v3 11/12] iio: dac: ad5686: read_raw/write_raw: use guard(mutex)()
From: Andy Shevchenko
Date: Tue Jun 16 2026 - 06:44:14 EST
On Tue, Jun 16, 2026 at 09:21:17AM +0100, Rodrigo Alencar via B4 Relay wrote:
> Use guarded mutex lock to facilitate code review when adding new
> attributes. This will allow for early returns, avoiding error-prone
> locking and unlocking in error paths. This also adds missing include
> linux/cleanup.h. Gain-control support will allow the scale attribute
> to be configurable.
What about interrupt handler? You just added yet another mutex lock/unlock
there. Perhaps this patch should be done before the previous one?
--
With Best Regards,
Andy Shevchenko