Re: [PATCH v3 RESEND 5/5] arm64: dts: qcom: Add device tree for SA8797P Ride board

[Konrad Dybcio]

On 5/26/26 7:13 AM, Shawn Guo wrote:
> From: Deepti Jaggi <deepti.jaggi@xxxxxxxxxxxxxxxx>
> 
> Add initial device tree for the Qualcomm SA8797P Ride reference board.
> 
>  - Configure UART15 as the primary console and UART4 as the secondary
>    serial port
>  - Enable UFS storage support
>  - Define thermal zones for PMIC dies, UFS, and two SDRAM sensors,
>    all sourced from SCMI sensor protocol on channel 23
> 
> Signed-off-by: Deepti Jaggi <deepti.jaggi@xxxxxxxxxxxxxxxx>
> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> ---

[...]

> +&thermal_zones {
> +	pm_kobra_thermal: pm-a-die-thermal {
> +		polling-delay-passive = <100>;
> +		polling-delay = <0>;

0 is the default value, you can drop these lines

[...]

> +	pm_kai_0_thermal: pm-e-die-thermal {

s/pm/pmic

> +		polling-delay-passive = <100>;
> +		polling-delay = <0>;
> +		thermal-sensors = <&scmi23_sensor 4>;
> +
> +		trips {
> +			trip0 {
> +				temperature = <115000>;
> +				hysteresis = <5000>;
> +				type = "passive";
> +			};
> +
> +			trip1 {
> +				temperature = <135000>;
> +				hysteresis = <5000>;
> +				type = "passive";
> +			};

Do we need two passive trip points?

Konrad