Re: [PATCH 2/4] dt-bindings: arm: qcom: Add Lenovo Yoga Slim 7x Gen11

[Konrad Dybcio]

On 6/12/26 6:05 PM, Rob Herring wrote:
> On Thu, Jun 11, 2026 at 03:48:15PM +0200, Krzysztof Kozlowski wrote:
>> On 10/06/2026 15:31, Abel Vesa wrote:
>>>>>>>> @@ -68,6 +68,7 @@ properties:
>>>>>>>>
>>>>>>>>        - items:
>>>>>>>>            - enum:
>>>>>>>> +              - lenovo,yoga-slim7x-gen11
>>>>>>>
>>>>>>> I imagine you might want different panel variants, just like T14s has
>>>>>>> LCD and OLED?
>>>>>>
>>>>>> I expect this will be the case.
>>>>>
>>>>> Then better to prepare for this now, otherwise later you need to change
>>>>> bindings. If unsure what other variants are, then at least make this
>>>>> compatible panel-specific, e.g. lenovo,yoga-slim7x-gen11-oled-foo-bar.
>>>>
>>>> I took another look at psref [1] and there's only OLED SKUs (today?).
>>>> There are however, two different resolutions available and both can be
>>>> touch/notouch.
>>>
>>> If the other SKU doesn't have touch, then you might as well mark now this
>>> one with touch suffix or something like that.
>>
>>
>> If you decide not to have any changes (new compatibles), then at least
>> please document the above reasoning in commit msg.
> 
> If the difference is just the panel or touch, then isn't that captured 
> by the panel and/or touch nodes?

We already have a couple of DTs for laptops where the touchscreen may
be there or not, with the additional hid-over-i2c node defined
unconditionally and it works out fine

For the panel, it depends.. If it's another "Samsung ATNA"-class panel
(which I would guess is the case, but can't know for sure), and there's
no other changes, then it would work too.

I opened the build configurator on the Lenovo website and I can order
both kinds of panels with both kinds of SoCs (X2 Plus / Elite)

> OTOH, if it's different firmware builds and generally treated as 2 
> different devices, then different top-level compatible is probably fine.

I unfortunately don't know the answer to that question.. 

They all carry the same model number on the website, it seems

Should we go forward with an optimistic, single compatible for the known
variant ("lenovo,yoga-slim7x-gen11", "qcom,glymur") then?

Konrad