Re: [PATCH v5] arm64: dts: qcom: glymur: add coresight nodes

From: Konrad Dybcio

Date: Tue Jun 16 2026 - 07:54:14 EST


On 6/12/26 1:11 AM, Jie Gan wrote:
>
>
> On 6/11/2026 5:28 PM, Konrad Dybcio wrote:
>> On 5/19/26 3:14 PM, Jie Gan wrote:
>>> Add CoreSight nodes to enable trace paths like TPDM->ETF/STM->ETF.
>>> These devices are part of the AOSS, CDSP, QDSS, PCIe5, TraceNoc and
>>> some small subsystems, such as GCC, IPCC, PMU and so on.
>>>
>>> Delete cti_wpss DT node on Mahua since this device will cause NoC issue
>>> on Mahua device.
>>
>> Another good explanation is that it simply doesn't exist there!
>>
>>> Signed-off-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>
>>> ---
>>
>> [...]
>>
>>
>>> +    tpdm-cdsp-llm {
>>
>> Nodes without a unit address should be sorted alphabetically
>>
>>> +        compatible = "qcom,coresight-static-tpdm";
>>> +        qcom,cmb-element-bits = <32>;
>>
>> Do these other TPDMs not have the "DSB element" as the driver
>> calls it?
>
> Depends on the design of the TPDM.
>
> tpdm-cdsp-llm here only supports CMB mode.
>
> There are three types of TPDM:
> CMB only
> DSB only
> support both

OK, thank you

Konrad