Re: [PATCH v2 4/5] workqueue: Show all busy workers in stall diagnostics

[Breno Leitao]

Hello Petr,

On Tue, Jun 16, 2026 at 02:38:11PM +0200, Petr Mladek wrote:
> On Thu 2026-06-11 07:50:04, Breno Leitao wrote:
> >
> > Unfortunately I didn't get the other pr_info(), because of console settings,
> > but, I can say the following from this issue and previous code:
> > 
> > 1) in show_cpu_pool_hog, found_running variable is set to false.
> > 2) hash_for_each() never found any running task
> > 3) The following code was trigger and was very helpful:
> > 
> >          if (!found_running)
> >                 trigger_single_cpu_backtrace(cpu);
> 
> Great. So, the extra complexity was worth it. Should I clean it and
> send a proper patch? Or would you like to do so?

I am happy to do so. I had a chat with tejun yesterday, and I got the
impression he is OK with this patch as well.

> Also I wonder whether it would make sense to revert the commit
> 8823eaef45da7f ("workqueue: Show all busy workers in stall
> diagnostics").

This patch undo that change already. Would you like to see a full revert
or, are you OK with this patch reverting that behaviour? Maybe with
a fixes: tag?

> If I get it correctly then printing all busy workers
> was not that helpful. Namely, the sleeping workers should not prevent
> progress.

Ack!