Re: [PATCH v6 14/14] selftests/mm: add writable-file collapse tests for khugepaged

From: David Hildenbrand (Arm)

Date: Tue Jun 16 2026 - 09:23:52 EST


On 5/17/26 15:54, Zi Yan wrote:
> collapse_file() now supports collapsing clean pagecache folios from
> writable files, so add corresponding tests.
>
> Note that madvise(MADV_COLLAPSE) works for dirty pagecache folios from
> writable files, because collapse_single_pmd() triggers a synchronous
> writeback when first attempt of collapse_file() fails. That writeback
> makes dirty folios clean and the retry of collapse_file() succeeds.
>
> Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> Cc: Barry Song <baohua@xxxxxxxxxx>
> Cc: Chris Mason <clm@xxxxxx>
> Cc: Christian Brauner <brauner@xxxxxxxxxx>
> Cc: David Hildenbrand (Arm) <david@xxxxxxxxxx>
> Cc: David Sterba <dsterba@xxxxxxxx>
> Cc: Dev Jain <dev.jain@xxxxxxx>
> Cc: Jan Kara <jack@xxxxxxx>
> Cc: Lance Yang <lance.yang@xxxxxxxxx>
> Cc: Liam Howlett <liam@xxxxxxxxxxxxx>
> Cc: Lorenzo Stoakes <ljs@xxxxxxxxxx>
> Cc: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Cc: Mike Rapoport <rppt@xxxxxxxxxx>
> Cc: Nico Pache <npache@xxxxxxxxxx>
> Cc: Ryan Roberts <ryan.roberts@xxxxxxx>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Cc: Song Liu <songliubraving@xxxxxx>
> Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Cc: Vlastimil Babka <vbabka@xxxxxxxxxx>
> ---

Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

--
Cheers,

David