Re: [PATCH v4 1/3] arm64: dts: qcom: sdm670: add default uart pinctrl nodes

[Konrad Dybcio]

On 6/1/26 6:55 PM, Pablo Correa Gómez via B4 Relay wrote:
> From: Pablo Correa Gómez <pabloyoyoista@xxxxxxxxxxxxxxxx>
> 
> This is a pre-requisite to enable UART in sargo and bonito. Values for
> the pins have been taken from sdm845, and cross-checking dowstream,
> where available.
> 
> Signed-off-by: Pablo Correa Gómez <pabloyoyoista@xxxxxxxxxxxxxxxx>
> ---

[...]

> +			qup_uart0_default: qup-uart0-default-state {
> +				qup_uart0_tx: tx-pins {
> +					pins = "gpio2";
> +					function = "qup0";
> +				};
> +
> +				qup_uart0_rx: rx-pins {
> +					pins = "gpio3";
> +					function = "qup0";
> +				};

Let's drop the unused labels and let's bring the default config
(bias-disable + drive-strength = <2>) to the SoC DT, like we have
in glymur.dtsi

Please also cross-check whether the pull-up you enable in your
phone's DT is actually necessary (and whether it's defined as such
in the vendor DT - FWIW it's not in the sdm670-pinctrl.dtsi common
one)

Konrad