Re: [PATCH] net: ethtool: mm: Increase FPE verification retry count
From: Vladimir Oltean
Date: Tue Jun 16 2026 - 11:18:17 EST
On Tue, Jun 16, 2026 at 08:19:25AM +0100, Simon Horman wrote:
> + Vladimir
>
> On Mon, Jun 15, 2026 at 12:24:36AM -0700, muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx wrote:
> > From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx>
> >
> > The current FPE verification retry count is set to 3. However,
> > the IEEE 802.3br standard does not specify a fixed value for this.
> > A retry count of 3 may be insufficient when the remote device is
> > slow to respond during link-up. Increase the retry count to 20 to
> > improve robustness.
> >
> > Signed-off-by: Rohan G Thomas <rohan.g.thomas@xxxxxxxxxx>
> > Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx>
>
> Vladimir, I'm wondering if you could take a look at this one.
IEEE 802.3br is an obsolete standard, I don't even have access to it.
IEEE 802.3-2022 is the current one for the MAC Merge layer. Clause
99.4.7.2 Constants states:
verifyLimit: the integer 3, the number of verification attempts
I don't have something in principle against making the verifyLimit
configurable past IEEE 802.3 for debugging purposes or non-standard
applications, but keep the default to 3.