Re: [PATCH v2 5/6] rust: Add dma_fence abstractions
From: Onur Özkan
Date: Tue Jun 16 2026 - 12:45:29 EST
On Tue, 16 Jun 2026 17:28:04 +0200
Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
> On Tue Jun 16, 2026 at 4:51 PM CEST, Onur Özkan wrote:
> > repr(C) only makes sense when the type have multiple fields.
>
> I don't think that's universally true. repr(transparent) guarantees the layout
> and ABI match the inner field. The wrapper is passed through calls exactly as
> the field would be. repr(C) guarantees C-compatible layout and makes the type
> follow the platform's C ABI for passing an aggregate, which isn't always how the
> bare field is passed.
I was too focused on the field ordering perspective during the review, sorry for
that.
Onur