[PATCH 1/5] x86/setup: remove unreachable memblock_reserve() return value check
From: Sang-Heon Jeon
Date: Tue Jun 16 2026 - 14:30:28 EST
trim_snb_memory() runs from early_reserve_memory() in setup_arch(), before
e820__memblock_setup() calls memblock_allow_resize(). At that point
memblock_reserve() either succeeds or panics, never returning an error.
Therefore the return value check is unreachable, so remove it and the
related logic.
No functional change.
Signed-off-by: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>
---
arch/x86/kernel/setup.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 46882ce79c3a..f9395bc632ca 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -742,11 +742,8 @@ static void __init trim_snb_memory(void)
* setup_arch(), so there is no need to reserve it here.
*/
- for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
- if (memblock_reserve(bad_pages[i], PAGE_SIZE))
- printk(KERN_WARNING "failed to reserve 0x%08lx\n",
- bad_pages[i]);
- }
+ for (i = 0; i < ARRAY_SIZE(bad_pages); i++)
+ memblock_reserve(bad_pages[i], PAGE_SIZE);
}
static void __init trim_bios_range(void)
--
2.43.0