Re: [PATCH] netdevsim: Fix deadlock in del_device_store() and nsim_bus_exit()

From: Jakub Kicinski

Date: Tue Jun 16 2026 - 18:40:16 EST


On Tue, 16 Jun 2026 22:26:44 +0000 Moksh Panicker wrote:
> mutex_lock(&nsim_bus_dev_list_lock);
> - list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list) {
> + list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list)
> list_del(&nsim_bus_dev->list);
> - nsim_bus_dev_del(nsim_bus_dev);
> - }
> mutex_unlock(&nsim_bus_dev_list_lock);
> + list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list)
> + nsim_bus_dev_del(nsim_bus_dev);

How could this possibly work?
--
pw-bot: cr