Re: [PATCH] ASoC: rsnd: adg: make rsnd_adg_clk_control() idempotent

[Kuninori Morimoto]

Hi John

> > 	- #define rsnd_adg_clk_enable(priv)	...
> > 	- #define rsnd_adg_clk_disable(priv)	...
> > 	- int rsnd_adg_clk_control(...);
> > 	+ #define rsnd_adg_clk_enable(priv)
> > 	+ #define rsnd_adg_clk_disable(priv)
> 
> Agreed, that reads much better. Splitting the two directions also lets
> the new flag handling fall out naturally: the enable side sets the flag
> on success and the disable side just early-returns when it is already
> disabled, so the "set clk_enabled = true before the rollback" trick from
> this patch goes away. The shared teardown moves into a small
> __rsnd_adg_clk_disable() helper used both by the public disable and as
> the enable() error rollback.

Thank you. But, your original patch-set has already applied, and it is
merge window now. So from your point of view, you want to include its
solution patch as much as possible ?

I think your this patch (= ASoC: rsnd: adg: make rsnd_adg_clk_control()
idempotent) can be applied in -rcX, because of bug fix.

And, the clk_control() separation patch is new feature. It can be for next
kernel ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto