Re: [PATCH 4/4] arm64: dts: qcom: Add PMIH0108 haptics device node

[Fenglin Wu]

On 6/16/2026 6:27 PM, Konrad Dybcio wrote:
> On 6/16/26 12:08 PM, Fenglin Wu wrote:
> > Add haptics device node in the PMIH0108 PMIC base dtsi files, and enable
> > it on several boards according to the LRA (Linear Resonant Actuator)
> > component mounted on each of them.
> >
> > Signed-off-by: Fenglin Wu <fenglin.wu@xxxxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/kaanapali-mtp.dts       | 7 +++++++
> >   arch/arm64/boot/dts/qcom/kaanapali-qrd.dts       | 7 +++++++
> >   arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi | 9 +++++++++
> >   arch/arm64/boot/dts/qcom/pmih0108.dtsi           | 9 +++++++++
> >   arch/arm64/boot/dts/qcom/sm8750-mtp.dts          | 7 +++++++
> >   arch/arm64/boot/dts/qcom/sm8750-qrd.dts          | 7 +++++++
> One commit per board, please
>
> >   6 files changed, 46 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> > index 07247dc98b70..7e3f59fc008e 100644
> > --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> > @@ -952,6 +952,13 @@ wifi@0 {
> >   	};
> >   };
> >   
> > +&pmih0108_e1_haptics {
> > +	status = "okay";
> 'status' should go last
>
> > +
> > +	qcom,lra-period-us = <6667>;
> > +	qcom,vmax-mv = <3600>;
> Do these properties depend on the physical characteristics on what's
> connected to the other end of the haptics driver?

Correct. They are basically the parameters of the LRA that's used on the 
board. You can find details of them in the binding document.

> Konrad