Re: [RESEND PATCH v1] net: dsa: motorcomm: add yt92xx dsa driver

[Kyle Switch]

On 6/15/26 23:01, Julian Braha wrote:
> Hi Kyle,
> 
> On 6/15/26 12:12, Kyle Switch wrote:
> 
>> diff --git a/drivers/net/dsa/motorcomm/Kconfig b/drivers/net/dsa/motorcomm/Kconfig
>> new file mode 100644
>> index 000000000000..f40d75e2a3f2
>> --- /dev/null
>> +++ b/drivers/net/dsa/motorcomm/Kconfig
>> @@ -0,0 +1,30 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +
>> +config MOTORCOMM
>> +	tristate "Motorcomm YT92XX switch family support"
>> +	depends on NET_DSA
>> +	select FIXED_PHY
>> +	help
>> +	  This driver adds support for Motorcomm switch chips. It supports
>> +	  YT921X and YT922X switch.
>> +
>> +choice
>> +	prompt "Motorcomm switch series selection"
>> +	depends on MOTORCOMM
>> +
>> +config MOTORCOMM_YT921X
>> +	bool "Motorcomm YT921X series."
>> +
>> +config MOTORCOMM_YT922X
>> +	bool "Motorcomm YT922X series."
>> +endchoice
>> +
>> +config NET_DSA_MOTORCOMM
>> +	tristate "Motorcomm YT92XX switch DSA driver"
>> +	depends on MOTORCOMM
>> +	depends on (MOTORCOMM_YT921X || MOTORCOMM_YT922X)
>> +	select NET_DSA_TAG_MOTORCOMM
>> +	select NET_IEEE8021Q_HELPERS if DCB
>> +	help
>> +	  Select to enable support for Motorcomm driver.
>> +
>> diff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm/Makefile
> NET_DSA_MOTORCOMM already depends on:
> (MOTORCOMM_YT921X || MOTORCOMM_YT922X)
> with both of those options depending on MOTORCOMM due to the 'choice'
> that they're in, so this additional dependency on MOTORCOMM is
> unnecessary.
> 
> You could also consider using a comment to document that this option is
> depended on indirectly.

Ans: agreed, i will fix this later.
> 
> - Julian Braha