Re: [PATCH 1/2] dt-bindings: soc: qcom: Document CDSP Power Management

[Krzysztof Kozlowski]

On 26/05/2026 09:57, Vignesh Viswanathan wrote:
>>
>>> +
>>> +  vdd-mx-supply:
>>> +    description:
>>> +      Phandle to the MX voltage regulator. This is the actual hardware regulator
>>> +      (e.g., from MP8899 PMIC) that supplies power to the CDSP MX rail. Optional
>>> +      on boards where MX rail is always-on or not present.
>>> +
>>> +  regulators:
>>> +    type: object
>>> +    description:
>>> +      Virtual regulators provided by this driver for consumption by the CDSP
>>> +      remoteproc driver. These virtual regulators pass through enable/disable
>>> +      requests to the actual hardware regulators (vdd-cx-supply, vdd-mx-supply).
>>
>> These regulators doesn't exist in reality, they are only here because
>> you choose to split the description of your remoteproc implementation in
>> two.
> 
> Yes, this is because the actual regulator can be controlled by two independent entities,
> the standard PAS driver and this CDSP driver when CDSP requests via the SMEM channel.

There is no such entity as PAS driver and CDSP driver. You are mixing
the hardware with Linux drivers.

Best regards,
Krzysztof