Re: [PATCH 6/7] hwmon: adm1275: Support ROHM BD12790

[Matti Vaittinen]

On 16/06/2026 17:15, Guenter Roeck wrote:
> On 6/15/26 23:44, Matti Vaittinen wrote:
> > From: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> >
> > Add support for ROHM BD12790 hot-swap controller which is largely
> > similar to Analog Devices adm1272.
> >
> > The BD12790 uses the same selectable 60V/100V voltage ranges and
> > 15mV/30mV current-sense ranges as the ADM1272, and the same VRANGE
> > (bit 5) and IRANGE (bit 0) layout in PMON_CONFIG. It therefore uses
> > a dedicated coefficient table that mirrors adm1272_coefficients, with
> > the following differences derived from BD12790 datasheet Table 1 (p.18):
> > - power 60V/30mV: m=17560 (vs. 17561)
> > - power 100V/30mV: m=10536 (vs. 10535)
> > - temperature: b=31880 (vs. 31871, reflecting T[11:0] = 4.2*T + 3188)
> >
> > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> > Assisted-by: GitHub Copilot:claude-sonnet-4.6
> >
> > ---

// snip

> > -/* The BD12780 data sheets mark TSFILT bit as reserved. */
> > -#define BD12780_PMON_DEFCONFIG        (ADM1278_VOUT_EN | 
> > ADM1278_TEMP1_EN)
> > +/* The BD127x0 data sheets mark TSFILT bit as reserved. */
> > +#define BD127X0_PMON_DEFCONFIG        (ADM1278_VOUT_EN | 
> > ADM1278_TEMP1_EN)
>
> Please don't use such placeholders. Just use BD12780_PMON_DEFCONFIG
> for both chips, similar to how the defines for all other chips
> are handled.

Ok, thanks.

Yours,
	-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~