Re: [PATCH] rust: kbuild: Replace and dissolve procmacro-extension variable
From: Nicolas Schier
Date: Wed Jun 17 2026 - 03:47:39 EST
On Tue, Jun 16, 2026 at 05:40:42AM -0700, Tamir Duberstein wrote:
> On Tue, Jun 16, 2026 at 7:26 AM Nicolas Schier <n.schier@xxxxxxxxx> wrote:
> >
> > Use make's $(suffix) function [1] and substitution reference [2] instead
> > of $(patsubst) to extract crate names for rust procmacro targets.
>
> The implementation uses `$(basename)`, not `$(suffix)`. Please update
> the commit message accordingly. Link [1] can remain, since it
> documents both functions.
uh yes, thanks! My first attempt was based on $(suffix) but then I
forgot to update that here, too.
I am going to send a v2 in a few hours.
> Otherwise this looks good to me.
Thanks!
Kind regards,
Nicolas