Re: [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs

[Laurent Pinchart]

On Wed, Jun 17, 2026 at 04:07:55PM +0800, Damon Ding wrote:
> Add static qualifier for of_display_mode_bridge_funcs to resolve the
> sparse warning:
> 
> drivers/gpu/drm/bridge/of-display-mode-bridge.c:54:25: sparse: sparse:
> symbol 'of_display_mode_bridge_funcs' was not declared. Should it be
> static?
> 
> Also mark the structure const as required by devm_drm_bridge_alloc()
> parameter type constraints.
> 
> Fixes: ba2db93cf3d5 ("drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606170744.FUStcWaB-lkp@xxxxxxxxx/
> Signed-off-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/bridge/of-display-mode-bridge.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/of-display-mode-bridge.c b/drivers/gpu/drm/bridge/of-display-mode-bridge.c
> index cb15713f3a79..e66dae168fd0 100644
> --- a/drivers/gpu/drm/bridge/of-display-mode-bridge.c
> +++ b/drivers/gpu/drm/bridge/of-display-mode-bridge.c
> @@ -51,7 +51,7 @@ static int of_display_mode_bridge_get_modes(struct drm_bridge *bridge,
>  	return 0;
>  }
>  
> -struct drm_bridge_funcs of_display_mode_bridge_funcs = {
> +static const struct drm_bridge_funcs of_display_mode_bridge_funcs = {
>  	.attach = of_display_mode_bridge_attach,
>  	.get_modes = of_display_mode_bridge_get_modes,
>  };

-- 
Regards,

Laurent Pinchart