Re: [PATCH net-next v6 1/2] dinghai: add ZTE network driver support

[Uwe Kleine-König]

Hello,

On Tue, Jun 16, 2026 at 09:30:57PM +0800, han.junyang@xxxxxxxxxx wrote:
> +static const struct pci_device_id dh_pf_pci_table[] = {
> +	{ PCI_DEVICE(ZXDH_PF_VENDOR_ID, ZXDH_PF_DEVICE_ID), 0 },
> +	{ PCI_DEVICE(ZXDH_PF_VENDOR_ID, ZXDH_VF_DEVICE_ID), 0 },
> +	{ 0, }
> +};

Please make this:

+static const struct pci_device_id dh_pf_pci_table[] = {
+	{ PCI_DEVICE(ZXDH_PF_VENDOR_ID, ZXDH_PF_DEVICE_ID) },
+	{ PCI_DEVICE(ZXDH_PF_VENDOR_ID, ZXDH_VF_DEVICE_ID) },
+	{ }
+};

(because the assignment to .driver_data is superflous and initializing
it using a list expression is in the way for one of my patch quests).

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature