Re: [RESEND PATCH v1] net: dsa: motorcomm: add yt92xx dsa driver

[Andrew Lunn]

> Thank you for your reminding, this patch will submitted  in a series 
> of small patches.
> This patch mainly contains three contents:
> 1. Underlying function interface for different motorcomm switch series in 
> the file driver/net/dsa/motorcomm/switch/.
> 2. Optimization existing yt921x dsa driver using common switch function apis.
> 3. New yt922x dsa driver.
> Can you accept break this up into lots of small patch according to this logic?
> if not, do you have any suggestion? thank you.

We need to see the patches, but keep them small, and add functionality
little by little. I had a very quick look at your first version, and i
see a lot you will need to change. So just post small bits of code,
learn from the review comments, and fixup all the rest of the code
before posting it.

One thing i need to point out. Linux has a long tradition of not
replacing existing code with a new implementation. You take the
existing code and step by step improve it. So i do not want to see a
patch which just removes the existing driver. I want to see patches
which add new functionality to the existing driver, doing refactors as
needed.

Please also remember:

MOTORCOMM YT921X ETHERNET SWITCH DRIVER
M:      David Yang <mmyangfl@xxxxxxxxx>
L:      netdev@xxxxxxxxxxxxxxx
S:      Maintained
F:      Documentation/devicetree/bindings/net/dsa/motorcomm,yt921x.yaml
F:      drivers/net/dsa/yt921x.*
F:      net/dsa/tag_yt921x.c

David is the Maintainer of this driver. Listen to what he says. In
time, when you have shown you can also can do the job of being a
Maintainer, your name will be added.

      Andrew