Re: [PATCH] rocker: Fix memory leak in ofdpa_port_fdb()

[Andrew Lunn]

On Tue, Jun 16, 2026 at 04:29:59PM -0700, Jacob Keller wrote:
> On 6/15/2026 6:32 PM, Ziran Zhang wrote:
> > In ofdpa_port_fdb(), the hash_del() only unlinks the node from
> > hash table, but does not free it.
> > 
> > Fix this by adding kfree(found) after the !found == removing check,
> > where the pointer value is no longer needed.
> > 
> > Found by Coccinelle kfree script.
> > 

Is rocker actually used any more? I'm not too sure of the history, but
was it not added as a way to develop the early switchdev code? There
was a qemu implementation of the 'hardware'?

Is it still useful? Should we actually just remove the driver?

	Andrew