Re: [PATCH 2/4] iio: adc: add ti-ads112c14 driver

[Andy Shevchenko]

On Tue, Jun 16, 2026 at 10:38:05AM -0500, David Lechner wrote:
> On 6/16/26 2:32 AM, Andy Shevchenko wrote:
> > On Mon, Jun 15, 2026 at 05:00:00PM -0500, David Lechner (TI) wrote:

...

> >> +	if (ret != -EREMOTEIO)
> >> +		return ret;
> > 
> > I would do it separately as
> > 
> > 	if (ret == -EREMOTEIO)
> > 		/* ...big comment here... */
> > 		return 0;

What I meant here is

		ret = 0;

Sorry for the confusion.

> We should not return early here. We just continue with the rest
> of the function as normal. So I think the way I had it was
> simplest. Otherwise we would need a goto or something like that.
> 
> 
> > 	if (ret) // which is regular pattern and doesn't need any comment.
> > 		return ret;

-- 
With Best Regards,
Andy Shevchenko