Re: [PATCH] drm/xe: Remove redundant exec_queue_suspended() check in submit_exec_queue()

[Rodrigo Vivi]

On Wed, Jun 17, 2026 at 09:25:16AM +0800, yaolu@xxxxxxxxxx wrote:
> From: Lu Yao <yaolu@xxxxxxxxxx>
> 
> There already has a check for exec_queue_suspended(q) that returns early
> if suspended.
> 
> Fixes: ec4cbdd163f9 ("drm/xe/multi_queue: skip submit when primary queue is suspended")

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

and pushed, thanks for the patch

> Signed-off-by: Lu Yao <yaolu@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 42110e01b7d0..dce0ecb7ea35 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1159,7 +1159,7 @@ static void submit_exec_queue(struct xe_exec_queue *q, struct xe_sched_job *job)
>  	if (exec_queue_suspended(q))
>  		return;
>  
> -	if (!exec_queue_enabled(q) && !exec_queue_suspended(q)) {
> +	if (!exec_queue_enabled(q)) {
>  		action[len++] = XE_GUC_ACTION_SCHED_CONTEXT_MODE_SET;
>  		action[len++] = q->guc->id;
>  		action[len++] = GUC_CONTEXT_ENABLE;
> -- 
> 2.25.1
>