Re: [PATCH 15/78] ASoC: codecs: cs42l43: Use guard() for mutex locks
From: Charles Keepax
Date: Wed Jun 17 2026 - 07:00:04 EST
On Wed, Jun 17, 2026 at 05:31:32PM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Clean up the code using guard() for mutex locks.
> Merely code refactoring, and no behavior change.
>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
> @@ -913,17 +908,13 @@ int cs42l43_jack_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *u
> if (override >= e->items)
> return -EINVAL;
>
> - mutex_lock(&priv->jack_lock);
> + guard(mutex)(&priv->jack_lock);
I believe you have to use scoped_guard here, as there is a return
from the function above, if memory serves it attempts to release
the mutex on that path despite it being above the guard.
Be worth having a quick scan through the rest of the series for
this as well.
Thanks,
Charles