Re: [PATCH v9 0/6] Add driver for EC found on Qualcomm reference devices

[Anthony Ruhier]

Tested-by: Anthony Ruhier <aruhier@xxxxxxxxxxx>

Thanks, I tested it on the slim 7x (2024) on which I was previously using the
first patches from Maya, it works great!

I confirm that the following works: keyboard backlight shutdowns when
suspended, led blinks when suspended, keyboard fn shortcuts.

For the Slim 7x, I needed to add the following in the DTS:

---

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index b5247fb91299..423bf7340b83 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -1070,6 +1070,21 @@ retimer_ss0_con_sbu_out: endpoint {
        };
 };

+&i2c5 {
+       clock-frequency = <400000>;
+       status = "okay";
+
+       embedded-controller@76 {
+               compatible = "qcom,hamoa-crd-ec";
+               reg = <0x76>;
+
+               interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+               pinctrl-0 = <&ec_int_n_default>;
+               pinctrl-names = "default";
+       };
+};
+
 &i2c7 {
        clock-frequency = <400000>;

@@ -1487,6 +1502,12 @@ reset-n-pins {
                };
        };

+       ec_int_n_default: ec-int-n-state {
+               pins = "gpio66";
+               function = "gpio";
+               bias-disable;
+       };
+
        edp_reg_en: edp-reg-en-state {
                pins = "gpio70";
                function = "gpio";


--
Anthony Ruhier