Re: [PATCH v7 3/8] selftests/cgroup: use runtime page size for zswpin check

[Michal Koutný]

On Fri, Apr 24, 2026 at 12:00:54PM +0800, Li Wang <li.wang@xxxxxxxxx> wrote:
> test_zswapin compares memory.stat:zswpin (counted in pages) against a
> byte threshold converted with PAGE_SIZE. In cgroup selftests, PAGE_SIZE
> is hardcoded to 4096, which makes the conversion wrong on systems with
> non-4K base pages (e.g. 64K).
> 
> As a result, the test requires too many pages to pass and fails
> spuriously even when zswap is working.
> 
> Use sysconf(_SC_PAGESIZE) for the zswpin threshold conversion so the
> check matches the actual system page size.
> 
> Signed-off-by: Li Wang <li.wang@xxxxxxxxx>
> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxxxx>
> Cc: Michal Koutný <mkoutny@xxxxxxxx>
> Cc: Muchun Song <muchun.song@xxxxxxxxx>
> Cc: Nhat Pham <nphamcs@xxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Roman Gushchin <roman.gushchin@xxxxxxxxx>
> Cc: Shakeel Butt <shakeel.butt@xxxxxxxxx>
> Reviewed-by: Yosry Ahmed <yosry@xxxxxxxxxx>
> Acked-by: Nhat Pham <nphamcs@xxxxxxxxx>
>
Reviewed-by: Michal Koutný <mkoutny@xxxxxxxx>

Attachment: signature.asc
Description: PGP signature