Re: [PATCH v7 5/8] selftests/cgroup: replace hardcoded page size values in test_zswap
From: Michal Koutný
Date: Wed Jun 17 2026 - 08:34:50 EST
On Fri, Apr 24, 2026 at 12:00:56PM +0800, Li Wang <li.wang@xxxxxxxxx> wrote:
> @@ -752,6 +753,10 @@ int main(int argc, char **argv)
> char root[PATH_MAX];
> int i;
>
> + page_size = sysconf(_SC_PAGE_SIZE);
> + if (page_size <= 0)
> + page_size = BUF_SIZE;
> +
I'd just fail the whole test if this fails. To have page_size always
represent what it says. (When can this fail anyway? Maybe nommu archs?)
(Rest looks good.)
Attachment:
signature.asc
Description: PGP signature