Re: [PATCH v1 3/6] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks

From: Prasad Kumpatla

Date: Wed Jun 17 2026 - 09:34:45 EST


On 6/11/2026 2:29 PM, Krzysztof Kozlowski wrote:
On 10/06/2026 17:45, Prasad Kumpatla wrote:
Add the LPASS Audio IF clock IDs used by newer backend interfaces.

Platforms using Audio IF module backends request the interface bit
clocks through q6prm. Add the Audio IF IBIT and EBIT IDs to the binding
header so these clocks can be referenced from device trees.

Signed-off-by: Prasad Kumpatla <prasad.kumpatla@xxxxxxxxxxxxxxxx>
---
.../sound/qcom,q6dsp-lpass-ports.h | 57 +++++++++++++++++++
1 file changed, 57 insertions(+)

diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
index 45850f2d4..bc860fcbf 100644
--- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
+++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
@@ -233,6 +233,63 @@
/* Clock ID for RX CORE MCLK2 2X MCLK */
#define LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK 70
+/** Clock ID of the Audio Intf 0 internal bit clock (IBIT). */
+#define LPASS_CLK_ID_AUD_INTF0_IBIT 71
Missing indent

Hi Krzysztof,

Thanks for reviewing and comments.

Ack, will update


+/** Clock ID of the Audio Intf 0 external bit clock (EBIT). */
This is not kerneldoc. Please do not introduce your own style.
Sure will remove and add proper comments if required.

+#define LPASS_CLK_ID_AUD_INTF0_EBIT 72
Why everything has "AUD" middle prefix? What is Audio IF and how does it
differ from Audio on this device? IOW, Why Audio has to be specified? Is
there non-Audio block?
Agree, As this is already audio, it may not required to use again AUD in the macro to represent. Will update.

+/** Clock ID of the Audio Intf 1 internal bit clock (IBIT). */
All these comments are pointless - you repeat the define name. Explain
once what is ibit, ebit etc, not every time.

Sure, we add comments if required.

Thanks,

Prasad


Best regards,
Krzysztof