Re: [PATCH] dmaengine: dw-axi-dmac: fix __le32 on set of CH_CTL_H_LLI_VALID

[Frank Li]

On Wed, Jun 17, 2026 at 09:49:43AM +0100, Ben Dooks wrote:
>
> When writing the lli->ctl_hi, this is an __le32 type so the
> value being orred should be convered to __le32 by cpu_to_le32.

Not sure if it can pass sparse warning check.

Frank
>
> Fixes 1deb96c0fa58a ("dmaegine: dw-axi-dmac: Support device_prep_dma_cyclic()")
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> --
> Note, the call to axi_chan_irq_clear() is passing lli->status_lo
> through which is also an __le32 but it does not seem to be set
> anywhere. Is this also a bug?
> ---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 4d53f077e9d2..8311df2f11bb 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1123,7 +1123,7 @@ static void axi_chan_block_xfer_complete(struct axi_dma_chan *chan)
>                                 hw_desc = &desc->hw_desc[i];
>                                 if (hw_desc->llp == llp) {
>                                         axi_chan_irq_clear(chan, hw_desc->lli->status_lo);
> -                                       hw_desc->lli->ctl_hi |= CH_CTL_H_LLI_VALID;
> +                                       hw_desc->lli->ctl_hi |= cpu_to_le32(CH_CTL_H_LLI_VALID);
>                                         desc->completed_blocks = i;
>
>                                         if (((hw_desc->len * (i + 1)) % desc->period_len) == 0)
> --
> 2.37.2.352.g3c44437643
>