Re: [PATCH v21 03/21] perf evsel/evlist: Avoid unnecessary #includes

[Arnaldo Carvalho de Melo]

On Wed, Jun 17, 2026 at 09:23:52AM -0700, Ian Rogers wrote:
> On Wed, Jun 17, 2026 at 9:08 AM Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> >
> > On Mon, Jun 15, 2026 at 06:15:25PM -0700, Ian Rogers wrote:
> > > Use forward declarations and remove unnecessary #includes in
> > > evsel.h. Sort the forward declarations in evsel.h and evlist.h. Move
> > > some PMU code into evsel.c.
> > >
> > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> > > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> >
> > ⬢ [acme@toolbx perf-tools-next2]$ git log --oneline -5
> > ce69f4f6d7467ef4 (HEAD) perf evsel/evlist: Avoid unnecessary #includes
> > 23dce143f5ed0557 perf python: Add missed explicit dependencies
> > ca74d08280ad690f perf util: Sort includes and add missed explicit dependencies
> > 776bd9ac834556ab (x1/perf-tools-next, perf-tools-next.korg/tmp.perf-tools-next, perf-tools-next.korg/perf-tools-next, origin/perf-tools-next) perf bpf: Fix up build failure due to change of btf_vlen() return type
> > 522ae978ac720a91 (origin/perf/hardening-9) perf dso: Set standard errno on decompression failure
> > ⬢ [acme@toolbx perf-tools-next2]$
> >
> >   LD      /tmp/build/perf-tools-next2/util/scripting-engines/perf-util-in.o
> > make[3]: *** [/home/acme/git/perf-tools-next2/tools/build/Makefile.build:158: util] Error 2
> > make[2]: *** [Makefile.perf:573: /tmp/build/perf-tools-next2/perf-util-in.o] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >   LD      /tmp/build/perf-tools-next2/tests/perf-test-in.o
> >   LD      /tmp/build/perf-tools-next2/perf-test-in.o
> >   LD      /tmp/build/perf-tools-next2/perf-in.o
> > make[1]: *** [Makefile.perf:288: sub-make] Error 2
> > make: *** [Makefile:122: install-bin] Error 2
> > make: Leaving directory '/home/acme/git/perf-tools-next2/tools/perf'
> > ⬢ [acme@toolbx perf-tools-next2]$
> >
> > I added this to fix the build:
> >
> > ⬢ [acme@toolbx perf-tools-next2]$ git diff
> > diff --git a/tools/perf/util/aslr.c b/tools/perf/util/aslr.c
> > index 6a7542e7db827d1b..027695d967798487 100644
> > --- a/tools/perf/util/aslr.c
> > +++ b/tools/perf/util/aslr.c
> > @@ -13,6 +13,7 @@
> >  #include "session.h"
> >  #include "data.h"
> >  #include "dso.h"
> > +#include "pmu.h"
> >  #include "pmus.h"
> >
> >  #include <internal/lib.h>  /* page_size */
> > ⬢ [acme@toolbx perf-tools-next2]$
> >
> > Applied the series, now testing.
> 
> Thanks, I'd found the same aslr issue but was testing with fixing the
> wider issues you raised. Presumably the aslr code was depending on the
> the #include via evsel.h and so cleaning those up broke the build as
> the aslr code needed a fix.
> 
> Thanks for testing, I can rebase my fixes on top of the v21 changes
> assuming testing goes ok.

Since 7.1 was already released I'm inclined to push what I have, your
v21 series + this simple fix, so that it can sit in linux-next for a few
days and you would send fixes on top of it, ok?

I'm basically stopping merging patch series and switching to processing
just fixes so that I can send the PR to Linus by the end of this week.

I'll push what I have to tmp.perf-tools-next now.

- Arnaldo