Re: [PATCH v3 00/12] [PATCH v3 00/12] x86/resctrl: Add kernel-mode (e.g., PLZA) support to the resctrl subsystem

[Reinette Chatre]

Hi Babu,

On 6/17/26 8:56 AM, Babu Moger wrote:
> 
> The display will look like this when the system boots up.
> 
> # cat info/kernel_mode
>   inherit_ctrl_and_mon:
>   global_assign_ctrl_assign_mon_per_cpu:group=uninitialized
>   global_assign_ctrl_assign_mon_per_cpu:group=uninitialized
> 
> There will not be any group associated with "inherit_ctrl_and_mon".
> It is only used to switch from other two modes.

Just two nitpicks (adding the "[]" to indicate effective mode and fixing the
copy&paste duplicate mode names) to confirm that I think you actually intended to
write:

# cat info/kernel_mode
  [inherit_ctrl_and_mon:]
  global_assign_ctrl_inherit_mon_per_cpu:group=uninitialized
  global_assign_ctrl_assign_mon_per_cpu:group=uninitialized

I would like to propose that the user documentation contains something like
"the kernel mode is followed by a semi-colon separated list of properties"
This implementation does not require more than one property associated with a mode
so this does not need any code changes but adding that flexibility to the user
interface should help if some future kernel mode needs more than one property.
What do you think?

Reinette