Re: [PATCH v2] kdb: fix memory leak in kdb_setenv() when environment is full

[Doug Anderson]

Hi,

On Tue, Jun 16, 2026 at 6:49 PM Naveen Kumar Chaudhary
<naveen.osdev@xxxxxxxxx> wrote:
>
> When kdb_setenv() fails to find a free slot in __env[], the function
> returns KDB_ENVFULL without freeing the previously allocated string
> buffer 'ep', leaking memory on every failed call.
>
> Add the missing kfree(ep) before returning KDB_ENVFULL.
>
> Fixes: a30d4ff8193e ("kdb: remove usage of static environment buffer")
> Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@xxxxxxxxx>
> ---
>  kernel/debug/kdb/kdb_main.c | 1 +
>  1 file changed, 1 insertion(+)

Since I already provided my tag and this just implements the minor
review feedback I provided, you probably should have carried forward
my tag. In any case:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>