Re: [PATCH v4 3/4] nfsd: implement server-stats-get netlink handler

[Chuck Lever]

On Wed, Jun 17, 2026, at 1:52 PM, Jeff Layton wrote:
> On Wed, 2026-06-17 at 11:25 -0400, Jeff Layton wrote:
>> On Wed, 2026-06-17 at 09:18 -0400, Chuck Lever wrote:
>> > 
>> > On Wed, Jun 17, 2026, at 7:07 AM, Jeff Layton wrote:

>> > > Is there something that accesses this today that I'm not aware of? If
>> > > not, is there some future intent to add this to nfsstat?
>> > 
>> > I think nfsstat should display the wdeleg-getattr field. It has simply
>> > been forgotten.
>> > 
>> 
>> Ok. I'll plan to add it to the interface and send it in v5. nfs-utils
>> will need a follow-on patch to display the value. No promises on when
>> I'll do that, but it shouldn't be too hard.
>
> I have a drafted patch, but I'm not thrilled with it. wdeleg_getattr is
> weird in that it's not a statistic about server-side protocol
> operations. So, it ends up sort of sitting off on its own in nfsstat.
>
> What would you (and Dai) think about instead keeping and exposing
> server-side callback call counts? Then we could just add a new section
> to nfsstat server-side output with all of the callback operation counts
> in it. wdeleg_getattr would just be the count for CB_GETATTRs.
>
> Thoughts?

That sounds ideal.


-- 
Chuck Lever