Re: [PATCH] Support new NV140FHM-N5B and TM156VDXP25 edp panel

[Doug Anderson]

Hi,

On Wed, Jun 17, 2026 at 3:11 AM Haikun Zhou
<zhouhaikun5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>

Note: your ${SUBJECT} line is missing the proper prefixes. A better subject:

drm/panel-edp: Support NV140FHM-N5B and TM156VDXP25

I'll fix when applying.

> the NV140FHM-N5B need 200ms delays from the backlight on to valid data,

"the" should be capitalized ("The"). I'll fix when applying, plus some
other minor cleanups to this message.


> 100ms delays from backlight off to valid data, the TM156VDXP25 need
> 100ms delays from the backlight off to valid data.
>
> NV140FHM-N5B raw edid:
> 00 ff ff ff ff ff ff 00 09 e5 98 0d 00 00 00 00
> 10 23 01 04 a5 1f 11 78 01 c8 d5 95 5d 59 94 29
> 23 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 94 37 80 a0 70 38 3c 40 30 20
> 36 00 35 ae 10 00 00 1a 76 2c 80 a0 70 38 3c 40
> 30 20 36 00 35 ae 10 00 00 1a 00 00 00 fd 00 28
> 3c 44 44 0e 01 0a 20 20 20 20 20 20 00 00 00 fc
> 00 4e 56 31 34 30 46 48 4d 2d 4e 35 42 0a 01 87
>
> 70 20 79 02 00 81 00 15 74 1a 00 00 03 01 28 3c
> 00 00 53 ff 53 ff 3c 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f9 90
>
> TM156VDXP25 raw edid:
> 00 ff ff ff ff ff ff 00 51 a1 39 21 00 00 00 00
> 0d 24 01 04 a5 22 13 78 03 6e 95 99 5b 58 8d 28
> 21 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 af 2b 80 a0 70 38 28 40 30 20
> 36 00 58 c2 10 00 00 1a 00 00 00 fd 00 28 3c 43
> 43 0e 01 0a 20 20 20 20 20 20 00 00 00 fe 00 3d
> 4c 20 20 20 20 20 20 20 20 20 20 ff 00 00 00 fc
> 00 54 4d 31 35 36 56 44 58 50 32 35 0a 20 01 ef
>
> 70 20 79 02 00 21 00 1d 72 0d 90 07 80 07 38 04
> 80 95 69 5b 8d 95 8d 87 42 21 02 35 54 b0 5c b0
> 5c 00 42 12 78 22 00 14 ff 21 02 85 7f 07 9f 00
> 2f 00 1f 00 37 04 27 00 02 00 05 00 2b 00 0c 27
> 00 28 3b 00 00 27 00 28 3b 00 00 2e 00 06 00 42
> b0 5c b0 5c 81 00 1e 72 1a 00 00 03 01 28 3c 00
> 00 53 ff 53 ff 3c 00 00 00 00 e3 05 04 00 e6 06
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90 90
>
> Signed-off-by: Haikun Zhou <zhouhaikun5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 81e1866d54e78..3e6d8f17c3072 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -2010,6 +2010,15 @@ static const struct panel_delay delay_80_500_e50_d50 = {
>         .disable = 50,
>  };
>
> +static const struct panel_delay delay_200_500_e50_po2e200_d100 = {
> +       .hpd_absent = 200,
> +       .unprepare = 500,
> +       .enable = 50,
> +       .powered_on_to_enable = 200,
> +       .disable = 100,
> +};
> +
> +

Checkpatch in strict mode yells.

-:68: CHECK:LINE_SPACING: Please don't use multiple blank lines
#68: FILE: drivers/gpu/drm/panel/panel-edp.c:1900:
+
+

I can fix when applying.

Also: not that there's any great way to sort these timings structures,
but I feel it belongs immediately after "delay_200_500_e50_po2e200"
since it's so similar. I'll move it.


>  #define EDP_PANEL_ENTRY(vend_chr_0, vend_chr_1, vend_chr_2, product_id, _delay, _name) \
>  { \
>         .ident = { \
> @@ -2144,6 +2153,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cfa, &delay_200_500_e50, "NV116WHM-A4D"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d45, &delay_200_500_e80, "NV116WHM-N4B"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d73, &delay_200_500_e80, "NE140WUM-N6S"),
> +       EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d98, &delay_200_500_e50_po2e200_d100, "NV140FHM-N5B"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0db3, &delay_200_500_e80, "NV153WUM-N42"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ddf, &delay_200_500_e80, "NV116WHM-T01"),
>
> @@ -2250,6 +2260,7 @@ static const struct edp_panel_entry edp_panels[] = {
>
>         EDP_PANEL_ENTRY('T', 'M', 'A', 0x0811, &delay_200_500_e80_d50, "TM140VDXP01-04"),
>         EDP_PANEL_ENTRY('T', 'M', 'A', 0x2094, &delay_200_500_e50_d100, "TL140VDMS03-01"),
> +       EDP_PANEL_ENTRY('T', 'M', 'A', 0x2139, &delay_200_500_e50_d100, "TM156VDXP25"),

Wow, I had to do quite a few manual fixups when applying. :( Please
work with others in your organization to learn how to more correclty
post up patches.

[1/1] drm/panel-edp: Support NV140FHM-N5B and TM156VDXP25
      commit: b9e2d5cdaab05c997be3a69d9b372d7676683e1b


-Doug