Re: [syzbot] [net?] WARNING in tls_err_abort
From: Jakub Kicinski
Date: Wed Jun 17 2026 - 17:14:34 EST
On Wed, 17 Jun 2026 12:00:31 +0200 Sabrina Dubroca wrote:
> 2026-06-16, 23:46:28 +0200, Sabrina Dubroca wrote:
> > 2026-06-16, 14:23:59 -0700, Jakub Kicinski wrote:
> > > In which case the question is whether we should try to remove
> > > the sock_error() instead? (stating the obvious I guess)
> >
> > That would make sense, but we can't prevent sock_error() being called
> > from some helper.
>
> Actually, getsockopt(SO_ERROR) will also clear sk_err. If we want to
> prevent further state transitions, we'll have to use something else
> (probably a flag in tls_context set by tls_err_abort()).
>
> So I'd go with 2 separate patches. The 2nd one will be a change in
> userspace-visible behavior, but hopefully not one they'd be upset
> about.
Seems reasonable, FWIW