Re: [PATCH v3] net: mvneta_bm: add suspend/resume support to prevent crash after resume

[Jakub Kicinski]

On Tue, 16 Jun 2026 19:25:40 +0800 Yun Zhou wrote:
> Add a device_link (DL_FLAG_AUTOREMOVE_CONSUMER) in mvneta_probe to
> guarantee BM resumes before mvneta and suspends after mvneta.

You say "guarantee" but you pretty much ignore the failure to add it:

+				if (!device_link_add(&pdev->dev,
+						     &pp->bm_priv->pdev->dev,
+						     DL_FLAG_AUTOREMOVE_CONSUMER))
+					dev_warn(&pdev->dev,
+						 "failed to create device link to BM\n");
 			}

Why not handle this error properly ?
-- 
pw-bot: cr