Re: [PATCH net v2] net: marvell: prestera: initialize err in prestera_port_sfp_bind

[Maxime Chevallier]

Hi,

On 6/17/26 21:32, Ruoyu Wang wrote:
> prestera_port_sfp_bind() returns err after walking the ports node. If no
> child node matches the port's front-panel id, err is never assigned.
> 
> Initialize err to 0 because absence of a matching optional port device
> tree node is not an error. In that case no phylink is created and port
> creation should continue with port->phy_link left NULL. Errors from
> malformed matched nodes and phylink_create() still propagate.
> 
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> Signed-off-by: Ruoyu Wang <ruoyuw560@xxxxxxxxx>

Sorry for the grumpiness, but Andrew did ask you to read :

  https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

and one of the first things it says it to wait 24h before a repost :/

The patch in itself LGTM, so :

Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Please wait 24h next time,

Maxime