Re: [PATCH 1/2] gpio: sch: use raw_spinlock_t in the irq startup path

From: Sebastian Andrzej Siewior

Date: Thu Jun 18 2026 - 04:19:37 EST


On 2026-06-18 09:41:50 [+0300], Andy Shevchenko wrote:
> On Thu, Jun 18, 2026 at 09:40:31AM +0300, Andy Shevchenko wrote:
> > On Thu, Jun 18, 2026 at 08:28:39AM +0200, Sebastian Andrzej Siewior wrote:
> > > On 2026-06-17 23:40:34 [+0800], Runyu Xiao wrote:
> > > > sch_irq_unmask() enables the GPIO IRQ and then updates the controller
> > > > state through sch_irq_mask_unmask(), which takes sch->lock with
> > > > spin_lock_irqsave(). The callback can be reached from irq_startup()
> > > > while setting up a requested IRQ. That path is not sleepable, but on
> > > > PREEMPT_RT a regular spinlock_t becomes a sleeping lock.
>
> > > > Fixes: 7a81638485c1 ("gpio: sch: Add edge event support")
> > > > Cc: stable@xxxxxxxxxxxxxxx
> > > > Signed-off-by: Runyu Xiao <runyu.xiao@xxxxxxxxxx>
> > >
> > > Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> >
> > There is already a v2.
>
> Or not... I might have been confused with other patch that got two versions
> in a row.

I am catching up so I wouldn't be surprised ;) And it is entirely
possible that sashiko came up with the pre-existing condition worth
fixing ;)

Sebastian