Re: [PATCH v2 14/17] afs: Remove erroneous seq |= 1 in volume lookup loop

[Oleg Nesterov]

On 06/18, David Howells wrote:
>
> This is an addendum to the patch to remove the erroneous seq |= 1 in volume
> lookup loop.
>
> Switch to using scoped_seqlock_read() as suggested by Oleg Nesterov[1].

Thanks, but

> --- a/fs/afs/internal.h
> +++ b/fs/afs/internal.h
> @@ -750,8 +750,6 @@ static inline void afs_vnode_set_cache(struct afs_vnode *vnode,
>  {
>  #ifdef CONFIG_AFS_FSCACHE
>  	vnode->netfs.cache = cookie;
> -	if (cookie)
> -		mapping_set_release_always(vnode->netfs.inode.i_mapping);
>  #endif

This change looks unrelated...

Oleg.