[PATCH v1 2/3] thunderbold: Assert that a service driver has a probe callback
From: Uwe Kleine-König (The Capable Hub)
Date: Thu Jun 18 2026 - 06:21:51 EST
tb_service_probe() calls the driver's probe function unconditionally.
Check at driver register time that this callback is valid to prevent a
NULL pointer exception.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
---
drivers/thunderbolt/xdomain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
index 86b2f7474670..05442df0e99c 100644
--- a/drivers/thunderbolt/xdomain.c
+++ b/drivers/thunderbolt/xdomain.c
@@ -968,6 +968,9 @@ tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr,
*/
int tb_register_service_driver(struct tb_service_driver *drv)
{
+ if (!drv->probe)
+ return -EINVAL;
+
drv->driver.bus = &tb_bus_type;
return driver_register(&drv->driver);
}
--
2.47.3